[Cherry-pick] [ONNX] Update fake mode usage in onnx docs (#135512) and Drop final None values as inputs for nodes in exporter graph (#135520)#136005
Merged
kit1980 merged 2 commits intopytorch:release/2.5from Sep 20, 2024
Conversation
Update fake mode usage in onnx docs Pull Request resolved: pytorch#135512 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 66db61f)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136005
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a24b970 with merge base b7eb725 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ytorch#135520) When value for an optional input is not provided, it is defaulted to `None`, which gets translates to "" in the onnx graph. To avoid this, if we have a list of inputs and the final few are all `None`, strip them in the graph. Pull Request resolved: pytorch#135520 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit e2f9a83)
kit1980
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1:
Update fake mode usage in onnx docs
Pull Request resolved: #135512 Approved by: https://github.com/justinchuby
Co-authored-by: Justin Chu justinchuby@users.noreply.github.com
(cherry picked from commit 66db61f)
PR 2:
Drop final None values as inputs for nodes in exporter graph
Pull Request resolved: #135520
(cherry picked from commit e2f9a83)