[Inductor] simplify indexing_exprs in LoopBody._init_with_copy (#135574)#135935
Merged
atalman merged 1 commit intopytorch:release/2.5from Sep 20, 2024
Merged
[Inductor] simplify indexing_exprs in LoopBody._init_with_copy (#135574)#135935atalman merged 1 commit intopytorch:release/2.5from
atalman merged 1 commit intopytorch:release/2.5from
Conversation
…ch#135574) This PR uses `var_ranges` information to simplify `indexing_exprs` in `LoopBody._init_with_copy` to to reduce occurrences of `FloorDiv` and `ModularIndexing` in the `indexing_exprs`. Pull Request resolved: pytorch#135574 Approved by: https://github.com/jgong5, https://github.com/leslie-fang-intel, https://github.com/jansel
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135935
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7286211 with merge base b7eb725 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jgong5
approved these changes
Sep 13, 2024
Collaborator
jgong5
left a comment
There was a problem hiding this comment.
Please clarify in the PR title/description that this is a fix for a regression issue.
jansel
approved these changes
Sep 16, 2024
Collaborator
Author
|
@pytorchbot merge |
Collaborator
|
PR targets release/2.5 rather than main, refusing merge request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the performance regression of GroupNorm in Inductor on CPU. This PR uses
var_rangesinformation to simplifyindexing_exprsinLoopBody._init_with_copyto reduce occurrences ofFloorDivandModularIndexingin theindexing_exprs.Pull Request resolved: #135574
Approved by: https://github.com/jgong5, https://github.com/leslie-fang-intel, https://github.com/jansel
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang