Skip to content

[Release Only] Disable flaky failing tests in release. Pin optree. Pin sympy#134489

Merged
atalman merged 7 commits intopytorch:release/2.4from
atalman:fix_release_builds
Aug 27, 2024
Merged

[Release Only] Disable flaky failing tests in release. Pin optree. Pin sympy#134489
atalman merged 7 commits intopytorch:release/2.4from
atalman:fix_release_builds

Conversation

@atalman
Copy link
Copy Markdown
Contributor

@atalman atalman commented Aug 26, 2024 •
edited
Loading

  1. test_segfault - is disabled on main as flaky failure
  2. test_outside_linear_module_free started failing on non related PR: [ROCm] Include hsa headers for rocm-triton whl #129235
  3. XLA_SKIP_XLA_OP_TESTS - The issue is that we used the python 3.9 way of annotating the type, but xla CI was in python 3.8. For xla we don't do minor releases so our XLA tag for 2.4 is already frozen.
  4. Pin optree==0.11.0
  5. Pin sympy in windows tests

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Aug 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134489

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 46f7c5c with merge base b66e3f0 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman mentioned this pull request Aug 26, 2024
Closed
@atalman atalman requested a review from a team as a code owner August 26, 2024 21:37
@JackCaoG
Copy link
Copy Markdown
Collaborator

JackCaoG commented Aug 26, 2024

xla change lgtm too

@atalman atalman added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 26, 2024
@atalman atalman changed the title [Release Only] Disable flaky failing tests in release [Release Only] Disable flaky failing tests in release. Pin optree. Aug 26, 2024
@atalman
Pin sympy to 1.13.1 (pytorch#133235)
cf77a5e 
Sympy 1.13.2 release yesterday, and it results in test failures on windows and mac

https://hud.pytorch.org/hud/pytorch/pytorch/454713fe9d11c3b70c28f1aaba74f5158f92d1ec/1?per_page=100

Hopefully these are the places it needs to get pinned
Pull Request resolved: pytorch#133235
Approved by: https://github.com/atalman, https://github.com/ZainRizvi
@atalman atalman requested a review from jeffdaily as a code owner August 26, 2024 23:27
@atalman atalman changed the title [Release Only] Disable flaky failing tests in release. Pin optree. [Release Only] Disable flaky failing tests in release. Pin optree. Pin sympy Aug 26, 2024
@atalman
Revert "fix sympy"
46f7c5c 
This reverts commit 864cd32.

Revert "Pin sympy to 1.13.1 (pytorch#133235)"

This reverts commit cf77a5e.

pin sympy win test
@atalman atalman merged commit e0ddbff into pytorch:release/2.4 Aug 27, 2024
@atalman atalman deleted the fix_release_builds branch August 27, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atalman @JackCaoG @kit1980