Skip to content

[CD] Add triton xpu wheel build#129730

Closed
chuanqi129 wants to merge 1 commit intopytorch:mainfrom
chuanqi129:xpu_triton
Closed

[CD] Add triton xpu wheel build#129730
chuanqi129 wants to merge 1 commit intopytorch:mainfrom
chuanqi129:xpu_triton

Conversation

@chuanqi129
Copy link
Copy Markdown
Collaborator

@chuanqi129 chuanqi129 commented Jun 28, 2024

Enable triton xpu wheel build firstly, then add pytorch xpu nightly wheel build, works for #114850

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jun 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129730

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 4280371 with merge base 8af58f6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@chuanqi129
Copy link
Copy Markdown
Collaborator Author

chuanqi129 commented Jun 28, 2024

Depends on triton xpu issue intel/intel-xpu-backend-for-triton#1505. Need triton xpu commit pin update PR #129847 land firstly. Have tested the new triton commit in https://github.com/pytorch/pytorch/actions/runs/9733469391/job/26860432767?pr=129730, and it works fine.

@chuanqi129 chuanqi129 force-pushed the xpu_triton branch 3 times, most recently from a6a0d79 to 83fcaa6 Compare June 28, 2024 19:12
@chuanqi129 chuanqi129 marked this pull request as ready for review June 28, 2024 19:13
@chuanqi129 chuanqi129 requested a review from a team as a code owner June 28, 2024 19:13
@chuanqi129 chuanqi129 marked this pull request as draft June 28, 2024 19:14
@chuanqi129 chuanqi129 force-pushed the xpu_triton branch 6 times, most recently from 51e201b to ef8158f Compare July 1, 2024 06:56
@chuanqi129 chuanqi129 marked this pull request as ready for review July 1, 2024 07:01
@chuanqi129 chuanqi129 requested review from EikanWang, atalman and etaf July 1, 2024 07:01
@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 2, 2024
@chuanqi129 chuanqi129 force-pushed the xpu_triton branch 6 times, most recently from 84747c7 to 2f58326 Compare July 4, 2024 06:45
Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# Triton xpu build use GCC11
if [[ "${BUILD_DEVICE}" == xpu ]]; then
docker exec -t "${container_name}" yum install -y devtoolset-11-gcc-c++
docker exec -t "${container_name}" bash -c "source /opt/rh/devtoolset-11/enable && ${PYTHON_EXECUTABLE} /pytorch/.github/scripts/build_triton_wheel.py --device=$BUILD_DEVICE $RELEASE"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we do something like this ?

if [[ "${BUILD_DEVICE}" == xpu ]]; then
            docker exec -t "${container_name}" yum install -y devtoolset-11-gcc-c++
            docker exec -t "${container_name}" bash -c "source /opt/rh/devtoolset-11/enable
fi
docker exec -t "${container_name}" bash -c "${PYTHON_EXECUTABLE} /pytorch/.github/scripts/build_triton_wheel.py --device=$BUILD_DEVICE $RELEASE"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately, we can't. Because the source /opt/rh/devtoolset-11/enable is only effective at that time. This change will let xpu use GCC9 again

@chuanqi129
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 4, 2024
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants