add checks in autograd c++ ops for double backward without retain_variables#1293
Closed
add checks in autograd c++ ops for double backward without retain_variables#1293
Conversation
soumith
commented
Apr 19, 2017
| auto BatchNormBackward::apply(const variable_list& grad_outputs) -> variable_list { | ||
| auto& input = this->input.unpack(); | ||
|
|
||
| if (!input) throw std::runtime_error("Trying to backward through the " |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
apaszke
reviewed
Apr 20, 2017
Contributor
apaszke
left a comment
There was a problem hiding this comment.
Can you rebase that commit on top of autograd?
| #ifndef PYTORCH_AUTOGRAD_ERRORS_H | ||
| #define PYTORCH_AUTOGRAD_ERRORS_H | ||
|
|
||
| #define PT_ERR_BACKWARD_TWICE "Trying to backward through the " \ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -0,0 +1,9 @@ | |||
| #ifndef PYTORCH_AUTOGRAD_ERRORS_H | |||
| #define PYTORCH_AUTOGRAD_ERRORS_H | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1288