[codemod][lowrisk] Remove extra semi colon from caffe2/caffe2/core/observer.h#126976
Closed
r-barnes wants to merge 1 commit intopytorch:mainfrom
Closed
[codemod][lowrisk] Remove extra semi colon from caffe2/caffe2/core/observer.h#126976r-barnes wants to merge 1 commit intopytorch:mainfrom
r-barnes wants to merge 1 commit intopytorch:mainfrom
Conversation
…server.h Summary: `-Wextra-semi` or `-Wextra-semi-stmt` If the code compiles, this is safe to land. Test Plan: Sandcastle Reviewed By: palmje Differential Revision: D57632765
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126976
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 25a2f4c with merge base f0366de ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57632765 |
Skylion007
approved these changes
May 23, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
-Wextra-semior-Wextra-semi-stmtIf the code compiles, this is safe to land.
Test Plan: Sandcastle
Reviewed By: palmje
Differential Revision: D57632765