Skip to content

Update conda to latest version for Docker release builds#125887

Closed
atalman wants to merge 3 commits intopytorch:mainfrom
atalman:fix_docker_release_nightly
Closed

Update conda to latest version for Docker release builds#125887
atalman wants to merge 3 commits intopytorch:mainfrom
atalman:fix_docker_release_nightly

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented May 10, 2024 •
edited
Loading

Fixes #125879

Issue is somewhat similar to this issue: #106470
doing:

conda install pytorch torchvision torchaudio pytorch-cuda=12.1 -c pytorch-nightly -c nvidia

pulls cpu version of pytorch,vision and audio here: https://github.com/pytorch/pytorch/actions/runs/9014006158/job/24795924934#step:11:6849

16 37.21     mpmath-1.2.1               |          py311_0         1.2 MB  pytorch-nightly
#16 37.21     nettle-3.7.3               |       hbbd107a_1         809 KB
#16 37.21     networkx-3.1               |  py311h06a4308_0         3.3 MB
#16 37.21     openh264-2.1.1             |       h4ff587b_0         711 KB
#16 37.21     pillow-9.3.0               |  py311h3fd9d12_2         874 KB  pytorch-nightly
#16 37.21     pytorch-2.4.0.dev20240509  |     py3.11_cpu_0        87.1 MB  pytorch-nightly
#16 37.21     pytorch-cuda-12.1          |       ha16c6d3_6           7 KB  pytorch-nightly
#16 37.21     pytorch-mutex-1.0          |              cpu           3 KB  pytorch-nightly
#16 37.21     sympy-1.12                 |  py311h06a4308_0        14.4 MB
#16 37.21     torchaudio-2.2.0.dev20240509|        py311_cpu         5.1 MB  pytorch-nightly
#16 37.21     torchvision-0.19.0.dev20240509|        py311_cpu         7.3 MB  pytorch-nightly

Updating conda to latest and rebuilding solved this issue.

@pytorch-bot
Copy link

pytorch-bot bot commented May 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125887

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 05f2bef with merge base 978b572 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 10, 2024
@bhack
Copy link
Contributor

bhack commented May 10, 2024

Is libmamba more reliable? It is a lot faster for sure
conda install -y -n base conda-libmamba-solver conda=24.4.0 && conda config --set solver libmamba

@bhack
Copy link
Contributor

bhack commented May 10, 2024

See more at https://conda.github.io/conda-libmamba-solver/user-guide/

@huydhn
Copy link
Contributor

huydhn commented May 10, 2024

Is that the default already for newer conda version? https://conda.org/blog/2023-11-06-conda-23-10-0-release/

@bhack
Copy link
Contributor

bhack commented May 10, 2024

I think it is ok cause we was still at 23.5.2 before this PR.

@atalman
Copy link
Contributor Author

atalman commented May 10, 2024

@pytorchmergebot merge -f "Docker builds and lint are passing"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented May 10, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@bhack
Copy link
Contributor

bhack commented May 14, 2024

Are the new nightly image pushed? See #125879 (comment)

@bhack
Copy link
Contributor

bhack commented May 15, 2024 •
edited
Loading

conda install pytorch torchvision torchaudio pytorch-cuda=12.4 -c pytorch-nightly -c nvidia is still installing cpu only version.

@malfet malfet mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CUDA nightly docker actually includes CPU build of torch

4 participants

@atalman @bhack @huydhn @pytorchmergebot