Skip to content

Aarch64 cd upgrade#123747

Closed
snadampal wants to merge 1 commit intopytorch:mainfrom
snadampal:aarch64_cd_upgrade
Closed

Aarch64 cd upgrade#123747
snadampal wants to merge 1 commit intopytorch:mainfrom
snadampal:aarch64_cd_upgrade

Conversation

@snadampal
Copy link
Copy Markdown
Collaborator

@snadampal snadampal requested a review from a team as a code owner April 10, 2024 18:50
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123747

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures

As of commit 91d5127 with merge base 713f065 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@snadampal
Copy link
Copy Markdown
Collaborator Author

Hi @atalman , this change requires the manylinux 2_28 docker for aarch64, the current one is manylinux 2014.

DOCKER_IMAGE: pytorch/manylinuxaarch64-builder:cpu-aarch64-main

Can you please update the image in the PyTorch account?

@mikaylagawarecki mikaylagawarecki requested a review from malfet April 11, 2024 18:50
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 11, 2024
@snadampal snadampal force-pushed the aarch64_cd_upgrade branch from 7c28fb4 to e405699 Compare April 12, 2024 04:00
@snadampal
Copy link
Copy Markdown
Collaborator Author

This PR is mainly to test the pytorch/builder CD script update PR: pytorch/builder#1781
I'm not sure how to read the CI test results in this case, the CI shows no issues, but it didn't test any of the generated workflows.
@malfet , can you please comment on this or pytorch/builder#1781

@malfet malfet marked this pull request as draft April 12, 2024 15:34
@malfet malfet added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Apr 12, 2024
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Apr 12, 2024

I'm not sure how to read the CI test results in this case, the CI shows no issues, but it didn't test any of the generated workflows.

You need to add ciflow/binaries_wheel label to trigger binary builds on PR

@snadampal snadampal force-pushed the aarch64_cd_upgrade branch from e405699 to 91d5127 Compare April 18, 2024 03:41
@snadampal
Copy link
Copy Markdown
Collaborator Author

This PR is blocked till the manylinux 2_28 docker workflow is merged, this is the PR# pytorch/builder#1784

@github-actions
Copy link
Copy Markdown
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jun 17, 2024
@github-actions github-actions bot closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR open source Stale topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants