Warn about local_rank not being globally unique.#12370
Closed
ezyang wants to merge 1 commit intopytorch:masterfrom
Closed
Warn about local_rank not being globally unique.#12370ezyang wants to merge 1 commit intopytorch:masterfrom
ezyang wants to merge 1 commit intopytorch:masterfrom
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
|
Wow, nice catch. Also should we follow up with taking an exclusive lock on a file when writing a checkpoint? |
pietern
approved these changes
Oct 5, 2018
Contributor
Author
|
It would be good if there were an official, well known, non-footgun way of saving checkpoints in this context. |
|
I think it's hard to completely eliminate "bad" behavior. For example, people could checkpoint a model in some local file, and then move the checkpoint to a network file system (https://github.com/stanford-futuredata/pytorch-distributed/blob/master/training/train_imagenet_nv.py#L408). But locks on files might be a good thing to do anyway. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edward Z. Yang ezyang@fb.com
CC @deepakn94