Delete noexcept on the move constructor of OrderedDict#12369
Closed
ezyang wants to merge 2 commits intopytorch:masterfrom
Closed
Delete noexcept on the move constructor of OrderedDict#12369ezyang wants to merge 2 commits intopytorch:masterfrom
ezyang wants to merge 2 commits intopytorch:masterfrom
Conversation
Previously we tested if default-construction was noexcept, which doesn't really mean that the move constructor is noexcept too. Shuts up clang-tidy. Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
goldsborough
approved these changes
Oct 5, 2018
Contributor
Author
|
Unfortunately, this doesn't compile on Windows. |
Contributor
Author
|
@pytorchbot retest this please |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we tested if default-construction was noexcept, which
doesn't really mean that the move constructor is noexcept too.
Shuts up clang-tidy.
Signed-off-by: Edward Z. Yang ezyang@fb.com
CC @goldsborough