Fix issues with ATenOp handling methods where self is not the first arg#12353
Closed
jamesr66a wants to merge 3 commits intopytorch:masterfrom
Closed
Fix issues with ATenOp handling methods where self is not the first arg#12353jamesr66a wants to merge 3 commits intopytorch:masterfrom
self is not the first arg#12353jamesr66a wants to merge 3 commits intopytorch:masterfrom
Conversation
b826a0a to
4ac670f
Compare
self is not the first arg
zdevito
approved these changes
Oct 5, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
added 3 commits
October 8, 2018 09:56
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
jamesr66a is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATenOp was handling
torch.whereincorrectly. Whereas thetorch.whereoverload (andaten::function) had arguments in the orderTensor condition, Tensor self, Tensor other, ATenOp was emitting code that assumed thatselfwas the 0th argument, and thus was trying to interpret the wrong value as the condition.