Skip to content

[ROCM] mark unit tests as working, skip failing unit test#12313

Closed
iotamudelta wants to merge 5 commits intopytorch:masterfrom
ROCm:unittests_20181003
Closed

[ROCM] mark unit tests as working, skip failing unit test#12313
iotamudelta wants to merge 5 commits intopytorch:masterfrom
ROCm:unittests_20181003

Conversation

@iotamudelta
Copy link
Contributor

@iotamudelta iotamudelta commented Oct 4, 2018

  • enabled fp16 tests for test_torch

  • enable fp16 tests for test_nn

  • enabled multilabelmargin loss for fp16

  • removed skip for test_pdist_empty_col

  • Enable test_nn tests that pass with compiler fixes etc.

  • Enable test_legacy_nn tests that pass with compiler fixes etc.

@ezyang @bddppq

@iotamudelta
mark unit tests as working, skip failing unit test (#240)
c1e06f3 
* enabled fp16 tests for test_torch

* enable fp16 tests for test_nn

* enabled multilabelmargin loss for fp16

* removed skip for test_pdist_empty_col

* Enable test_nn tests that pass with compiler fixes etc.

* Enable test_legacy_nn tests that pass with compiler fixes etc.
bddppq
bddppq reviewed Oct 4, 2018
View reviewed changes
test/test_cuda.py Outdated
def test_scatter_gpu(self):
self._test_scatter(torch.randn(4, 4).cuda(), dim=0)

@skipIfRocm

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@bddppq
Copy link
Contributor

bddppq commented Oct 4, 2018 •
edited
Loading

Triggered tests https://ci.pytorch.org/jenkins/job/pytorch-builds/job/py2-clang7-rocmdeb-ubuntu16.04-trigger/359/

@iotamudelta Before we re-enable running tests for PR, when you submit PR that affects rocm tests, please trigger the CI job here https://ci.pytorch.org/jenkins/job/pytorch-builds/job/py2-clang7-rocmdeb-ubuntu16.04-trigger/build?delay=0sec with GIT_COMMIT filled in with origin/pr/XXX/head where XXX is the PR number (in this case it's 12313)

@bddppq
Copy link
Contributor

bddppq commented Oct 4, 2018 •
edited
Loading

lint check failed

./test/test_nn.py:6926:9: E123 closing bracket does not match indentation of opening bracket's line
./test/test_nn.py:6940:9: E123 closing bracket does not match indentation of opening bracket's line
./test/test_nn.py:6965:9: E123 closing bracket does not match indentation of opening bracket's line

@bddppq bddppq changed the title mark unit tests as working, skip failing unit test [ROCM] mark unit tests as working, skip failing unit test Oct 4, 2018
facebook-github-bot
facebook-github-bot reviewed Oct 4, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bddppq bddppq added the module: rocm AMD GPU support for Pytorch label Oct 4, 2018
@bddppq bddppq self-requested a review October 4, 2018 06:31
@iotamudelta iotamudelta deleted the unittests_20181003 branch October 4, 2018 13:37
@iotamudelta iotamudelta restored the unittests_20181003 branch October 4, 2018 13:37
@iotamudelta iotamudelta deleted the unittests_20181003 branch October 23, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@ezyang ezyang Awaiting requested review from ezyang

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@bddppq bddppq bddppq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: rocm AMD GPU support for Pytorch open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iotamudelta @bddppq @facebook-github-bot @ezyang