[jit] Properly catch errors in PythonOps#12243
Closed
driazati wants to merge 1 commit intopytorch:masterfrom
driazati:python_err
Closed
[jit] Properly catch errors in PythonOps#12243driazati wants to merge 1 commit intopytorch:masterfrom driazati:python_err
driazati wants to merge 1 commit intopytorch:masterfrom
driazati:python_err
Conversation
If a PythonOp throws an error it raises an exception to the interpreter and also releases the GIL which causes [pybind to segfault](potassco/clingo#42) This fix catches pybind errors while the GIL is still held and throws a `python_error` to capture the GIL
apaszke
approved these changes
Oct 3, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a PythonOp throws an error it raises an exception to the interpreter and also releases the GIL which causes pybind to segfault
This fix catches pybind errors while the GIL is still held and throws a
python_errorto re-capture the GILFixes #12118
@apaszke