Fix ONNX bug, add symbolic for full#12052
Closed
apaszke wants to merge 2 commits intopytorch:masterfrom
Closed
Conversation
houseroad
reviewed
Sep 25, 2018
Member
houseroad
left a comment
There was a problem hiding this comment.
Overall, LG, can you add some test cases either in https://github.com/pytorch/pytorch/blob/master/test/onnx/test_operators.py or https://github.com/pytorch/pytorch/blob/master/test/onnx/test_pytorch_onnx_caffe2.py, or both? Thanks
| const_value = _maybe_get_const(value, 't') | ||
| if _is_value(const_value): | ||
| tmp = zeros(shape, scalar_type, layout, device) | ||
| return add(tmp, value, g.op("Constant", value_t=torch.tensor(1))) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
houseroad
approved these changes
Sep 26, 2018
Member
houseroad
left a comment
There was a problem hiding this comment.
The expect file looks correct, but very complicated.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.