[caffe2]Export symbols for pybind and other libs after caffe2 rebase#11975
[caffe2]Export symbols for pybind and other libs after caffe2 rebase#11975gujinghui wants to merge 1 commit intopytorch:masterfrom
Conversation
|
@yinghai pls help review |
|
What's the test command to show before and after this PR? |
|
The two failures above should be not related to ideep code. In recent master branch, the USE_IDEEP is always disabled, that's why there're so many issues... To enable iDEEP for caffe2 only, please try below config. |
|
Could you rebase on upon recent master? |
14ba7b5 to
538976b
Compare
|
@yinghai Done. pls have a try. |
|
@yinghai |
|
I think this is suspicious. Master doesn't have any failures. |
|
this was briefly broken on master. |
|
Did you intend to update the submodule? |
|
@pytorchbot retest this please |
facebook-github-bot
left a comment
There was a problem hiding this comment.
yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
yinghai
left a comment
There was a problem hiding this comment.
Cool! Looks like things are good. Next step would be unifying the build for MKLDNN.
caffe2/ideep/utils/ideep_context.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Signed-off-by: Gu, Jinghui <jinghui.gu@intel.com>
538976b to
d7df2c5
Compare
|
@yinghai |
facebook-github-bot
left a comment
There was a problem hiding this comment.
yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Export symbols for pybind and other libs after caffe2 rebase