[c2][serialized_tests] Refactor tests part 2#11811
Closed
ajyu wants to merge 1 commit intopytorch:masterfrom
Closed
[c2][serialized_tests] Refactor tests part 2#11811ajyu wants to merge 1 commit intopytorch:masterfrom
ajyu wants to merge 1 commit intopytorch:masterfrom
Conversation
Summary: Followup to the [first refactor](pytorch#11350). Increase coverage of tests Test Plan: Run test with `python -m pytest caffe2/python/operator_test/my_test.py` Reviewers: Subscribers: Tasks: Tags:
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ajyu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
houseroad
approved these changes
Sep 19, 2018
Member
houseroad
left a comment
There was a problem hiding this comment.
LG, in the next diff please generate a table, so we know which ops are already covered.
Contributor
Author
|
Will do, I'll check out your reference and do something similar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Followup to the first refactor. Increase coverage of tests
Test Plan: Run test with
python -m pytest caffe2/python/operator_test/my_test.pyReviewers: @houseroad
Subscribers: @dzhulgakov