Enable build_test on windows#11802
Closed
mingzhe09088 wants to merge 4 commits intopytorch:masterfrom
mingzhe09088:windows-test
Closed
Enable build_test on windows#11802mingzhe09088 wants to merge 4 commits intopytorch:masterfrom mingzhe09088:windows-test
mingzhe09088 wants to merge 4 commits intopytorch:masterfrom
mingzhe09088:windows-test
Conversation
Contributor
|
Yay! Windows passed at https://ci.pytorch.org/jenkins/job/pytorch-builds/job/pytorch-win-ws2016-cuda9-cudnn7-py3-trigger/21781/. Only failure was Caffe2 MKL. Retesting and also importing. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@pytorchbot retest this please |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
mingzhe09088 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
orionr
approved these changes
Sep 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables BUILD_TEST for Caffe2 on windows.