Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117822
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 9c449fb with merge base fdae936 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@jianyuh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
2 similar comments
|
@jianyuh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jianyuh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Rebase to the trunk? |
This PR depends on #115214 but it got reverted due to breaking the internal build. It's in the process of relanding. |
|
@jianyuh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Rebase failed due to Command Raised by https://github.com/pytorch/pytorch/actions/runs/7616139952 |
ddc2091 to
15662f1
Compare
|
Manual rebase after #115214 relanded. |
15662f1 to
4da61cb
Compare
|
@jianyuh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @jeffdaily , could you rebase to the trunk? There is a conflict with master so we couldn't import it internally and test the PR. Thanks! |
Done. |
|
@jianyuh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jianyuh
left a comment
There was a problem hiding this comment.
Is this PR ready for public / review ?
|
@jianyuh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 4 jobs have failed, first few of them are: trunk, linux-binary-manywheel, linux-binary-libtorch-cxx11-abi, linux-binary-libtorch-pre-cxx11 Details for Dev Infra teamRaised by workflow job |
|
@jeffdaily maybe fix the unit test given the merge has failed :) |
@xw285cornell Pushed commit to resolve the unit tests. You'll need to redo your import to resolve the Meta Internal-Only Changes Check that is now failing due to my new commit push. |
|
@jianyuh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@jeffdaily is there a recommended way to detect that the rocm gpu is "ROCm MI300+"? |
In torch C++, we have In torch python, we have |
scaled_gemm for ROCm using hipblaslt. As of ROCm 6.0, HIPBLASLT_MATMUL_DESC_AMAX_D_POINTER is not supported. A work-around is provided, performing the absmax operation on the output buffer, but this results in some loss of accuracy for the absmax result. For this reason the feature should be considered beta/preview.
cc @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang