[Caffe2][Training performance]Implementation MomentumSGD/MomentumSGDUpdate operators for mkl-dnn#11686
[Caffe2][Training performance]Implementation MomentumSGD/MomentumSGDUpdate operators for mkl-dnn#11686PenghuiCheng wants to merge 1 commit intopytorch:masterfrom
Conversation
|
@wesolwsk,Please review the commit. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
wesolwsk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Getting lots of errors as follows: caffe2/caffe2/core/operator.h: In instantiation of ‘const T& caffe2::OperatorBase::Input(int) [with T = caffe2::Tensor]’: |
0c93b19 to
17e68c9
Compare
|
@wesolwsk ,I had updated code. Please review it. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
wesolwsk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
please make the following fixes and rebase
|
17e68c9 to
c5bf9f1
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
wesolwsk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@wesolwsk ,for line 37 and line78,ShadowingClass warning,I didn't know how to change it,do you have some suggestions for this? |
the speed-up of a single operation is up to 6X on BDW.