VSX: Fix vectorized abs function for complex tensors#116859
Closed
Flamefire wants to merge 1 commit intopytorch:mainfrom
Closed
VSX: Fix vectorized abs function for complex tensors#116859Flamefire wants to merge 1 commit intopytorch:mainfrom
Flamefire wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116859
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 2901288 with merge base f692fc9 ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
|
@pytorchbot merge -r |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Use a similar approach with Sleef as in pytorch#99550 to improve the precision and extremal value handling of the `abs` function for complex tensors. This fixes - test_reference_numerics_extremal__refs_abs_cpu_float64 - test_reference_numerics_extremal__refs_abs_cpu_float128 which failed on PPC.
Collaborator
|
Successfully rebased |
3bb167a to
2901288
Compare
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a similar approach with Sleef as in #99550
to improve the precision and extremal value handling of the
absfunction for complex tensors.This fixes
which failed on PPC.
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10