Skip to content

Only join pin_memory_thread after it started#11599

Closed
ssnl wants to merge 2 commits intopytorch:masterfrom
ssnl:dll
Closed

Only join pin_memory_thread after it started#11599
ssnl wants to merge 2 commits intopytorch:masterfrom
ssnl:dll

Conversation

@ssnl
Copy link
Collaborator

@ssnl ssnl commented Sep 12, 2018

Same reason as in #11432 .

Example error:

Exception ignored in: <function _DataLoaderIter.__del__ at 0x7fa06963cf28>
Traceback (most recent call last):
  File "/private/home/ssnl/miniconda3/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 405, in __del__
    self._shutdown_workers()
  File "/private/home/ssnl/miniconda3/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 401, in _shutdown_workers
    self.pin_memory_thread.join()
AttributeError: '_DataLoaderIter' object has no attribute 'pin_memory_thread'

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SsnL has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants