Closed
Conversation
5b7fa95 to
d0f76be
Compare
ezyang
previously requested changes
Sep 9, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
spurious onnx update is spurious
Contributor
|
@zou3519 Should we remove the onnx submodule update? |
Contributor
Author
|
Well the problem hasn't been fixed yet :) |
Contributor
Author
|
@pytorchbot retest this please |
Collaborator
|
closing this. feel free to reopen if you still want to test. |
Contributor
Author
|
still testing |
d0f76be to
6073f30
Compare
Contributor
Author
|
We fixed the main cause of this (the high memory usage) in #10981 so this should be good to go now |
3f48890 to
8092bfe
Compare
8092bfe to
1634b44
Compare
ezyang
approved these changes
Sep 19, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.