Improve shape analysis to cover all most commonly used ops#11358
Improve shape analysis to cover all most commonly used ops#11358apaszke wants to merge 4 commits intopytorch:masterfrom
Conversation
zdevito
left a comment
There was a problem hiding this comment.
The code looks good, but this is a big change and there are no direct tests of this code. Due to how little optimization normally applies, it is very possible this code is wrong and we just don't see the effects in end-to-end runs. At the very least we should have one per operator category in shape_prop that creates a graph with a single op, runs shape prop, and checks that it matches what the op really does if it is run with example inputs.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
18ea4f1 to
d0928ce
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
caede43 to
3e5ad2a
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Here's a list of ops that are in
register_aten_ops.cpp, but aren't supported in shape prop. Everything else should work now.