[ROCM] enable skipped test_api cpp tests by hongxiayang · Pull Request #109817 · pytorch/pytorch

hongxiayang · 2023-09-21T19:33:02Z

[ROCM] enable skipped test_api cpp tests

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo

pytorch-bot · 2023-09-21T19:33:05Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109817

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 969b5b6 with merge base b1f1b39 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

hongxiayang · 2023-09-21T19:34:00Z

@pytorchbot label "topic: not user facing"

hongxiayang · 2023-09-21T21:05:14Z

@pytorchbot label ciflow/trunk

hongxiayang · 2023-09-27T15:55:07Z

all rocm tests passed;
(1) InitTest tests:

2023-09-25T20:53:02.0912320Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::InitTest::ProducesPyTorchValues_XavierUniform 
2023-09-25T20:53:02.0913240Z [gw0] [ 37%] PASSED [1.0980s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ModulesTest::BatchNorm1d 
2023-09-25T20:53:02.0914084Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ModulesTest::BatchNorm2dStateful 
2023-09-25T20:53:02.0914896Z [gw1] [ 37%] PASSED [0.9872s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::InitTest::ProducesPyTorchValues_XavierUniform 
2023-09-25T20:53:02.0915711Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::InitTest::ProducesPyTorchValues_XavierNormal 
2023-09-25T20:53:02.0916532Z [gw0] [ 37%] PASSED [0.9621s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ModulesTest::BatchNorm2dStateful 
2023-09-25T20:53:02.0917288Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ModulesTest::BatchNorm2dStateless 
2023-09-25T20:53:02.0918128Z [gw1] [ 37%] PASSED [0.9450s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::InitTest::ProducesPyTorchValues_XavierNormal 
2023-09-25T20:53:02.0918930Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::InitTest::ProducesPyTorchValues_KaimingNormal 
2023-09-25T20:53:02.0919753Z [gw0] [ 37%] PASSED [0.9538s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ModulesTest::BatchNorm2dStateless 
2023-09-25T20:53:02.0920489Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ModulesTest::BatchNorm2d 
2023-09-25T20:53:02.0921304Z [gw1] [ 37%] PASSED [0.9645s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::InitTest::ProducesPyTorchValues_KaimingNormal 
2023-09-25T20:53:02.0922097Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::InitTest::ProducesPyTorchValues_KaimingUniform 
2023-09-25T20:53:02.0922907Z [gw0] [ 37%] PASSED [1.0939s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ModulesTest::BatchNorm2d 
2023-09-25T20:53:02.0923650Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ModulesTest::BatchNorm3dStateful 
2023-09-25T20:53:02.0924483Z [gw1] [ 37%] PASSED [0.9616s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::InitTest::ProducesPyTorchValues_KaimingUniform 
2023-09-25T20:53:02.0925288Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::InitTest::CanInitializeTensorThatRequiresGrad 
2023-09-25T20:53:02.0926121Z [gw0] [ 38%] PASSED [0.9790s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ModulesTest::BatchNorm3dStateful 
2023-09-25T20:53:02.0926878Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ModulesTest::BatchNorm3dStateless 
2023-09-25T20:53:02.0927731Z [gw1] [ 38%] PASSED [1.0401s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::InitTest::CanInitializeTensorThatRequiresGrad 
2023-09-25T20:53:02.0928501Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::InitTest::CalculateGainWithTanh

(2) IntegrationTest tests:

2023-09-25T20:53:02.0941351Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::IntegrationTest::CartPole 
2023-09-25T20:53:02.0942126Z [gw0] [ 39%] PASSED [1.1081s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ModulesTest::InstanceNorm1d 
..
2023-09-25T20:53:02.0969092Z [gw1] [ 40%] PASSED [18.4347s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::IntegrationTest::CartPole 
2023-09-25T20:53:02.0969799Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::IntegrationTest::MNIST_CUDA 
..

(3) ParallelTest:

2023-09-25T20:53:02.1797552Z ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ParallelTest::DataParallelUsesAllAvailableCUDADevices_CUDA 
2023-09-25T20:53:02.1798035Z [gw0] [ 99%] PASSED [1.1544s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::OperationTest::Linear_out 
2023-09-25T20:53:02.1798610Z [gw1] [100%] PASSED [1.2784s] ../../../../../opt/conda/envs/py_3.8/lib/python3.8/site-packages/torch/bin/test_api::ParallelTest::DataParallelUsesAllAvailableCUDADevices_CUDA 
2023-09-25T20:53:02.1798622Z

test/cpp/api/CMakeLists.txt

jithunnair-amd · 2023-09-27T16:44:37Z

@kit1980 @malfet CI is clean. Enabling some more cpp_tests for ROCm.

malfet · 2023-09-27T16:50:08Z

@jithunnair-amd do you know how much longer it will take the CI to finish with those tests to add? ROCM runners were queued quite often last week. From https://hud.pytorch.org/metrics

malfet · 2023-09-27T16:50:54Z

@pytorchbot merge

pytorchmergebot · 2023-09-27T16:52:39Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[ROCM] enable skipped lazy and api cpp tests

661725f

pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Sep 21, 2023

pytorch-bot bot added the topic: not user facing topic category label Sep 21, 2023

pytorchbot added the open source label Sep 21, 2023

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 21, 2023

hongxiayang added 2 commits September 22, 2023 20:34

no LTC_TS_CUDA flag for test_jit

ccece76

revert changes about using LTC_TS_CUDA flag in rocm tests

969b5b6

hongxiayang changed the title ~~[ROCM] enable skipped lazy and api cpp tests~~ [ROCM] enable skipped test_api cpp tests Sep 25, 2023

hongxiayang marked this pull request as ready for review September 27, 2023 15:46

hongxiayang requested review from jithunnair-amd, kit1980 and malfet September 27, 2023 15:55

pruthvistony requested changes Sep 27, 2023

View reviewed changes

test/cpp/api/CMakeLists.txt Show resolved Hide resolved

hongxiayang requested a review from jeffdaily September 27, 2023 16:26

jithunnair-amd approved these changes Sep 27, 2023

View reviewed changes

malfet approved these changes Sep 27, 2023

View reviewed changes

pytorchmergebot added the merging label Sep 27, 2023

pytorchmergebot added Merged and removed merging labels Sep 27, 2023

pytorchmergebot closed this in 0511df0 Sep 27, 2023

jon-chuang mentioned this pull request Sep 27, 2023

CI: rocm (default, 1, 3, linux.rocm.gpu) is very slow #110181

Closed

jithunnair-amd added the rocm This tag is for PRs from ROCm team label Dec 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ROCM] enable skipped test_api cpp tests#109817

[ROCM] enable skipped test_api cpp tests#109817
hongxiayang wants to merge 3 commits intopytorch:mainfrom
hongxiayang:cpp_misc

hongxiayang commented Sep 21, 2023 •

edited

Loading

Uh oh!

pytorch-bot bot commented Sep 21, 2023 •

edited

Loading

Uh oh!

hongxiayang commented Sep 21, 2023

Uh oh!

hongxiayang commented Sep 21, 2023

Uh oh!

hongxiayang commented Sep 27, 2023

Uh oh!

Uh oh!

jithunnair-amd commented Sep 27, 2023 •

edited

Loading

Uh oh!

malfet commented Sep 27, 2023

Uh oh!

malfet commented Sep 27, 2023

Uh oh!

pytorchmergebot commented Sep 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

hongxiayang commented Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109817

✅ No Failures

Uh oh!

hongxiayang commented Sep 21, 2023

Uh oh!

hongxiayang commented Sep 21, 2023

Uh oh!

hongxiayang commented Sep 27, 2023

Uh oh!

Uh oh!

jithunnair-amd commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

malfet commented Sep 27, 2023

Uh oh!

malfet commented Sep 27, 2023

Uh oh!

pytorchmergebot commented Sep 27, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hongxiayang commented Sep 21, 2023 •

edited

Loading

pytorch-bot bot commented Sep 21, 2023 •

edited

Loading

jithunnair-amd commented Sep 27, 2023 •

edited

Loading