Skip to content

Added decorator skipRocmIfTorchInductor and skipped failing tests#107760

Closed
pragupta wants to merge 6 commits intopytorch:mainfrom
pragupta:skipRocmIfTorchInductor
Closed

Added decorator skipRocmIfTorchInductor and skipped failing tests#107760
pragupta wants to merge 6 commits intopytorch:mainfrom
pragupta:skipRocmIfTorchInductor

Conversation

@pragupta
Copy link
Copy Markdown
Collaborator

@pragupta pragupta commented Aug 23, 2023

This PR adds a skip decorator which will disable tests in CI for ROCm inductor workflow. This new workflow will be coming in via #110544

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

@pragupta pragupta requested review from a team, mruberry and ngimel as code owners August 23, 2023 02:48
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Aug 23, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107760

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 6c68801 with merge base 39ff801 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Aug 23, 2023
@pragupta
Copy link
Copy Markdown
Collaborator Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 23, 2023
@jataylo jataylo self-requested a review August 23, 2023 15:30
@jataylo jataylo added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/unstable Run all experimental or flaky jobs on PyTorch unstable workflow labels Aug 23, 2023
@jataylo jataylo marked this pull request as draft August 23, 2023 15:32
Copy link
Copy Markdown
Collaborator

@jataylo jataylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! lets test on CI

@pragupta pragupta force-pushed the skipRocmIfTorchInductor branch 2 times, most recently from 7b75fba to e3174a1 Compare August 25, 2023 16:49
@pragupta pragupta force-pushed the skipRocmIfTorchInductor branch from e3174a1 to eb6b005 Compare August 28, 2023 15:56
@pragupta pragupta marked this pull request as ready for review August 29, 2023 14:42
@pruthvistony pruthvistony added the rocm This tag is for PRs from ROCm team label Sep 8, 2023
@atalman
Copy link
Copy Markdown
Contributor

atalman commented Oct 10, 2023

please add proper PR description

@pragupta
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request ciflow/unstable Run all experimental or flaky jobs on PyTorch unstable workflow Merged module: rocm AMD GPU support for Pytorch open source rocm This tag is for PRs from ROCm team topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants