[Security] Use github environment for update-commit-hash workflow#107060
[Security] Use github environment for update-commit-hash workflow#107060atalman wants to merge 8 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107060
Note: Links to docs will display an error until the docs builds have been completed. ✅ 3 Unrelated FailuresAs of commit e23a0f0: UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
malfet
left a comment
There was a problem hiding this comment.
Sorry, I should have read it more carefully: I don't think one can specify the environment for a composite workflow, only for the top level one
No Issues I will rewrite _update-commit-hash.yml as reusable action this way it should work with top level workflow similar to this example: |
|
@pytorchbot merge -f "rocm failures are not related" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Similar to: #101718
https://github.com/pytorch/pytorch/actions/runs/5856611801/job/15876722301
Please note since we can't specify environment for a composite workflow. It was needed to move update-commit-hash as action rather then workflow.
Still todo: Move docs and binary builds