Closed
Conversation
Summary: Reduce minimal work size to 1 and see what happens to performance. I think that not spawing threads with spin-lock synchronization may be bad because they will switch to condvar wait, which increases wake-up latency next time they are needed. Reviewed By: ajtulloch Differential Revision: D9366664 fbshipit-source-id: f1d8dcceb971e6fd2f4e0a4236fcd15cef5e4759
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reduce minimal work size to 1 and see what happens to performance.
I think that not spawing threads with spin-lock synchronization may be bad because they will switch to condvar wait, which increases wake-up latency next time they are needed.
Reviewed By: ajtulloch
Differential Revision: D9366664