Skip to content

Enable running compiled optimizers in CI#104888

Closed
mlazos wants to merge 2 commits intomainfrom
mlazos/run-tests
Closed

Enable running compiled optimizers in CI#104888
mlazos wants to merge 2 commits intomainfrom
mlazos/run-tests

Conversation

@mlazos
Copy link
Copy Markdown
Contributor

@mlazos mlazos commented Jul 10, 2023 •
edited by janeyx99
Loading

@mlazos mlazos requested a review from janeyx99 July 10, 2023 17:49
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jul 10, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104888

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cc4c5f1:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the topic: not user facing topic category label Jul 10, 2023
janeyx99
janeyx99 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol we really landed enabling Adam foreach without the tests running in CI 🫠

@mlazos
Copy link
Copy Markdown
Contributor Author

mlazos commented Jul 10, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 10, 2023
@mlazos
Copy link
Copy Markdown
Contributor Author

mlazos commented Jul 10, 2023

lol we really landed enabling Adam foreach without the tests running in CI 🫠

Yep, at least it's still passing tho

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 10, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@janeyx99 janeyx99 changed the title Fix running compiled optimizers in CI Enable running compiled optimizers in CI (followup to #104121) Jul 10, 2023
@janeyx99 janeyx99 changed the title Enable running compiled optimizers in CI (followup to #104121) Enable running compiled optimizers in CI Jul 10, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 10, 2023

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mlazos
Copy link
Copy Markdown
Contributor Author

mlazos commented Jul 10, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 10, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions Bot deleted the mlazos/run-tests branch January 9, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mlazos @pytorchmergebot @janeyx99