🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102148

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

• [PREEMPTIVE] CPU amd64 non-GPU instances migration to Linux AMZN2023

❌ 10 New Failures, 1 Unrelated Failure

As of commit 351390b with merge base 907cc6c ():

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Hi, can you please add a test for it in test/test_mps.py?

Since there is an OpInfo for max_pool3d already, you can simply remove the following line and the consistency tests between cpu and mps will run automatically:

Also think you need to implement max_pool3d_with_indices* ops and adjust the decomp test in test_decomp.py since in MPS we treat w & w/o indices as separate kernels instead of sharing the same kernel and using CompositeImplicitAutograd. Let me know if you need any help!

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Hi, can you please add a test for it in test/test_mps.py?

Since there is an OpInfo for max_pool3d already, you can simply remove the following line and the consistency tests between cpu and mps will run automatically:

pytorch/test/test_mps.py

Line 490 in 8751002

'nn.functional.max_pool3d': None,

@Berzeg , thanks for the PR. Can you address comments from @qqaatw . Please let us know if you need help.

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Re-opening this to take it forward.

+1 for max_pool3d_with_indices and max_pool3d operations on mps

if this is pending, let me know. I'll be happy to contribute