-
Notifications
You must be signed in to change notification settings - Fork 27.7k
Remove support for multiple ellipses in slicing #59787
Copy link
Copy link
Open
Labels
module: advanced indexingRelated to x[i] = y, index functionsRelated to x[i] = y, index functionsmodule: deprecationmodule: python array apiIssues related to the Python Array APIIssues related to the Python Array APIneeds designWe want to add this feature but we need to figure out how firstWe want to add this feature but we need to figure out how firsttriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
Metadata
Metadata
Assignees
Labels
module: advanced indexingRelated to x[i] = y, index functionsRelated to x[i] = y, index functionsmodule: deprecationmodule: python array apiIssues related to the Python Array APIIssues related to the Python Array APIneeds designWe want to add this feature but we need to figure out how firstWe want to add this feature but we need to figure out how firsttriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
The array API specification stipulates that the slice for nd tensors shall contain at most one ellipsis (
...). PyTorch allows an arbitrary number:Not only is this behavior undocumented, it also makes no sense: what dimension would the
0applied to in the above example?cc @mruberry @rgommers @pmeier @asmeurer @leofang