🚀 Feature
Some test modules are using unittest.main() instead of torch.testing._internal.common_utils.run_tests(). Thus, the arg parser in common_utils are not running for these tests, which makes the whole test suite somewhat inconsistent.
|
parser = argparse.ArgumentParser(add_help=False) |
|
parser.add_argument('--subprocess', action='store_true', |
|
help='whether to run each test in a subprocess') |
|
parser.add_argument('--seed', type=int, default=1234) |
|
parser.add_argument('--accept', action='store_true') |
|
parser.add_argument('--jit_executor', type=str) |
|
parser.add_argument('--repeat', type=int, default=1) |
|
parser.add_argument('--test_bailouts', action='store_true') |
|
parser.add_argument('--save-xml', nargs='?', type=str, |
|
const=_get_test_report_path(), |
|
default=_get_test_report_path() if bool(os.environ.get('IN_CI')) else None) |
|
parser.add_argument('--discover-tests', action='store_true') |
|
parser.add_argument('--log-suffix', type=str, default="") |
|
parser.add_argument('--run-parallel', type=int, default=1) |
test_expecttest
test_mobile_optimizer
test_show_pickle
test_namedtuple_return_api
test_jit_disabled
test_overrides
test_tensorexpr
test_package
We encountered this in a problem while running tests
python test/run_test.py --verbose -- --save-xml -v
--save-xml should be passed to each test module, but some test modules not using common_utils.run_tests() don't have these parser and will just throw an error: unrecognized arguments: --save-xml
cc @mruberry @VitalyFedyunin @walterddr @ptrblck
🚀 Feature
Some test modules are using
unittest.main()instead oftorch.testing._internal.common_utils.run_tests(). Thus, the arg parser incommon_utilsare not running for these tests, which makes the whole test suite somewhat inconsistent.pytorch/torch/testing/_internal/common_utils.py
Lines 149 to 162 in 71766d8
We encountered this in a problem while running tests
--save-xmlshould be passed to each test module, but some test modules not usingcommon_utils.run_tests()don't have these parser and will just throw anerror: unrecognized arguments: --save-xmlcc @mruberry @VitalyFedyunin @walterddr @ptrblck