View tracking for autograd should not save optional std::function #49257
Description
Metadata
Metadata
Assignees
Labels
Relatively self-contained tasks for better engineering contributorsRelated to torch.autograd, and the autograd engine in generalWe think this is a small issue to fix. Consider knocking off high priority small issuesThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
In the view tracking for autograd in
torch/csrc/variable.h, we save the optional view function as anc10::optional<std::function<Variable(const Variable&)>>but thestd::functionclass already has an empty state.Unless there are performance reasons (see comment #49097 (comment)), the optional can be removed here.
cc @ezyang @albanD @zou3519 @gqchen @pearu @nikitaved