-
Notifications
You must be signed in to change notification settings - Fork 27.7k
Remove all self.assertEqualIgnoreTypes instances #38095
Copy link
Copy link
Closed
Labels
better-engineeringRelatively self-contained tasks for better engineering contributorsRelatively self-contained tasks for better engineering contributorsmodule: testsIssues related to tests (not the torch.testing module)Issues related to tests (not the torch.testing module)triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Metadata
Metadata
Assignees
Labels
better-engineeringRelatively self-contained tasks for better engineering contributorsRelatively self-contained tasks for better engineering contributorsmodule: testsIssues related to tests (not the torch.testing module)Issues related to tests (not the torch.testing module)triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
As
self.assertEqualnow compares tensor's dtypes as well as values, there are some number of tests which are unhappy with it. So we temporarily replaced such cases ofself.assertEqualwithself.assertEqualIgnoreTypes.However it is temporary measure, as
self.assertEqualIgnoreTypescalls need to be reviewed on case-by-case basis and replaced withself.assertEqualcalls and proper dtypes orself.assertEqualwithexact_dtype=Falsewherever it is not possible by design.All this tasks are searchable by:
TODO(#38095)after landing of #38102cc @mruberry