-
Notifications
You must be signed in to change notification settings - Fork 27.7k
Complex support for torch.remainder #34266
Copy link
Copy link
Closed
Labels
function requestA request for a new function or the addition of new arguments/modes to an existing function.A request for a new function or the addition of new arguments/modes to an existing function.module: complexRelated to complex number support in PyTorchRelated to complex number support in PyTorchtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
Metadata
Metadata
Assignees
Labels
function requestA request for a new function or the addition of new arguments/modes to an existing function.A request for a new function or the addition of new arguments/modes to an existing function.module: complexRelated to complex number support in PyTorchRelated to complex number support in PyTorchtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
🚀 Feature
Add complex number support for
torch.remainder.Motivation
When porting remainder from TH to ATen, I noticed that other operators, like
torch.div, have support for complex numbers. It wasn't mathematically clear to me how to implement support for complex numbers intorch.remainder, and since the original TH implementation did not have it, it was outside the scope of that issue.Pitch
@nikitaved explained some of the details of how complex support could be implemented in these comments:
#24753 (comment)
#24753 (comment)
cc @ezyang @anjali411 @dylanbespalko @mruberry