-
Notifications
You must be signed in to change notification settings - Fork 27.7k
Make what RPC module wants to expose clearer #27229
Copy link
Copy link
Closed
Labels
module: rpcRelated to RPC, distributed autograd, RRef, and distributed optimizerRelated to RPC, distributed autograd, RRef, and distributed optimizertodoNot as important as medium or high priority tasks, but we will work on these.Not as important as medium or high priority tasks, but we will work on these.triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
Metadata
Metadata
Assignees
Labels
module: rpcRelated to RPC, distributed autograd, RRef, and distributed optimizerRelated to RPC, distributed autograd, RRef, and distributed optimizertodoNot as important as medium or high priority tasks, but we will work on these.Not as important as medium or high priority tasks, but we will work on these.triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
This is to summarize maintability requests from #26919, #26997.
I think rpc should create a folder like
distributed/autograddoesMaintain the names want to be exposed to users in
torch/distributed/rpc/__init__.py.Do the actual implmentation in
torch/distributed/rpc/rpc_api.py.Also, do not use
from "something" import *, as descirebd in https://docs.quantifiedcode.com/python-anti-patterns/maintainability/from_module_import_all_used.html, it's not clear what has been imported to current module.cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma