-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Push based nightlies #26817
Copy link
Copy link
Closed
Labels
module: binariesAnything related to official binaries that we release to usersAnything related to official binaries that we release to userstriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
Our currently nightly structure is triggered by a cron job in CircleCI. The problem with cron triggered jobs is they don't have access to CircleCI context (see https://ideas.circleci.com/ideas/CCI-I-981), which means we can't legitimately access credentials to upload.
The proposed new structure is we maintain a "nightly" branch. This branch is fast-forwarded to master by a cron job run in FB infrastructure, using the SSH key of a role account that is authorized to access the context in question. We delete the cron job otherwise, and instead the nightly jobs with uploads are tied to a specific branch.
A nice property of this is we can manually retrigger a nightly whenever we want, by pushing to this branch.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
module: binariesAnything related to official binaries that we release to usersAnything related to official binaries that we release to userstriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module