Skip to content

Delete TensorOptions::operator== #25478

@ezyang

Description

@ezyang

We defined an equality test on TensorOptions but we really shouldn't have; the semantics are completely non-obvious.

What we should define instead is probably something like TensorAxes which is the tuple of (DeviceType, Layout, DType) which maps into TensorTypeId and uniquely specifies how dispatch computation happens. (Should Variable show up in here eventually? Probably.)

Metadata

Metadata

Assignees

Labels

enhancementNot as big of a feature, but technically not a bug. Should be easy to fixmodule: internalsRelated to internal abstractions in c10 and ATensmallWe think this is a small issue to fix. Consider knocking off high priority small issuestriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions