-
Notifications
You must be signed in to change notification settings - Fork 27.7k
Delete TensorOptions::operator== #25478
Copy link
Copy link
Open
Labels
enhancementNot as big of a feature, but technically not a bug. Should be easy to fixNot as big of a feature, but technically not a bug. Should be easy to fixmodule: internalsRelated to internal abstractions in c10 and ATenRelated to internal abstractions in c10 and ATensmallWe think this is a small issue to fix. Consider knocking off high priority small issuesWe think this is a small issue to fix. Consider knocking off high priority small issuestriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Metadata
Metadata
Assignees
Labels
enhancementNot as big of a feature, but technically not a bug. Should be easy to fixNot as big of a feature, but technically not a bug. Should be easy to fixmodule: internalsRelated to internal abstractions in c10 and ATenRelated to internal abstractions in c10 and ATensmallWe think this is a small issue to fix. Consider knocking off high priority small issuesWe think this is a small issue to fix. Consider knocking off high priority small issuestriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
We defined an equality test on TensorOptions but we really shouldn't have; the semantics are completely non-obvious.
What we should define instead is probably something like
TensorAxeswhich is the tuple of(DeviceType, Layout, DType)which maps into TensorTypeId and uniquely specifies how dispatch computation happens. (Should Variable show up in here eventually? Probably.)