-
Notifications
You must be signed in to change notification settings - Fork 27.4k
generate_opcheck_tests doesn't work with pytest-style test suites #108927
Copy link
Copy link
Closed
Labels
module: testingIssues related to the torch.testing module (not tests)Issues related to the torch.testing module (not tests)triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🐛 Describe the bug
There are two problems that I immediately ran into:
- pytest supports test classes that don't subclass unittest.TestCase, but generate_opcheck_tests requires it
- whatever process we use to generate new test methods doesn't preserve pytest mark parametrize, so you end up with test methods that don't get their parametrized arguments filled in
There may be other problems
cc @zou3519
Versions
main
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
module: testingIssues related to the torch.testing module (not tests)Issues related to the torch.testing module (not tests)triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module