Skip to content

Commit e1da5df

Browse files
albanDalbanD
committed
Update on "ger is an alias to outer, not the other way around"
Differential Revision: [D28900487](https://our.internmc.facebook.com/intern/diff/D28900487) [ghstack-poisoned]
2 parents a12a544 + f270687 commit e1da5df

210 files changed

Lines changed: 4964 additions & 4774 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.circleci/scripts/binary_populate_env.sh‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,12 @@ if [[ -z "$DOCKER_IMAGE" ]]; then
6868
fi
6969
fi
7070

71+
USE_GOLD_LINKER="OFF"
72+
# GOLD linker can not be used if CUPTI is statically linked into PyTorch, see https://github.com/pytorch/pytorch/issues/57744
73+
if [[ ${DESIRED_CUDA} == "cpu" ]]; then
74+
USE_GOLD_LINKER="ON"
75+
fi
76+
7177
# Default to nightly, since that's where this normally uploads to
7278
PIP_UPLOAD_FOLDER='nightly/'
7379
# We put this here so that OVERRIDE_PACKAGE_VERSION below can read from it
@@ -169,7 +175,7 @@ export CIRCLE_PR_NUMBER="${CIRCLE_PR_NUMBER:-}"
169175
export CIRCLE_BRANCH="$CIRCLE_BRANCH"
170176
export CIRCLE_WORKFLOW_ID="$CIRCLE_WORKFLOW_ID"
171177
172-
export USE_GOLD_LINKER=1
178+
export USE_GOLD_LINKER="${USE_GOLD_LINKER}"
173179
export USE_GLOO_WITH_OPENSSL=1
174180
# =================== The above code will be executed inside Docker container ===================
175181
EOL

‎.github/scale-config.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ runner_types:
2828
max_available: 50
2929
disk_size: 150
3030
windows.4xlarge:
31-
instance_type: c5.4xlarge
31+
instance_type: c5d.4xlarge
3232
os: windows
3333
max_available: 200
3434
disk_size: 256
3535
windows.8xlarge.nvidia.gpu:
36-
instance_type: g3.8xlarge
36+
instance_type: p3.2xlarge
3737
os: windows
3838
max_available: 25
3939
disk_size: 256

‎.github/templates/linux_ci_workflow.yml.j2‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,22 @@ jobs:
141141
-w /var/lib/jenkins/workspace \
142142
"${DOCKER_IMAGE}" \
143143
sh -c 'sudo chown -R jenkins . && .jenkins/pytorch/build.sh'
144+
- name: Display and upload binary build size statistics (Click Me)
145+
# temporary hack: set CIRCLE_* vars, until we update
146+
# tools/print_test_stats.py to natively support GitHub Actions
147+
env:
148+
SCRIBE_GRAPHQL_ACCESS_TOKEN: ${{ secrets.SCRIBE_GRAPHQL_ACCESS_TOKEN }}
149+
CIRCLE_BRANCH: ${{ steps.parse-ref.outputs.branch }}
150+
CIRCLE_PR_NUMBER: ${{ github.event.pull_request.number }}
151+
CIRCLE_SHA1: ${{ github.event.pull_request.head.sha || github.sha }}
152+
CIRCLE_TAG: ${{ steps.parse-ref.outputs.tag }}
153+
CIRCLE_WORKFLOW_ID: ${{ github.run_id }} # dunno if this corresponds
154+
run: |
155+
export PYTHONPATH=$PWD
156+
COMMIT_TIME=$(git log --max-count=1 --format=%ct || echo 0)
157+
export COMMIT_TIME
158+
pip3 install requests
159+
python3 .circleci/scripts/upload_binary_size_to_scuba.py || exit 0
144160
- name: Chown workspace
145161
run: |
146162
# Ensure the working directory gets chowned back to the current user
@@ -192,6 +208,8 @@ jobs:
192208
docker run --rm -v "$(pwd)/../":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .
193209
- name: Checkout PyTorch
194210
uses: actions/checkout@v2
211+
with:
212+
submodules: recursive
195213
- name: Pull docker image
196214
run: |
197215
docker pull "${DOCKER_IMAGE}"

‎.github/templates/windows_ci_workflow.yml.j2‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ jobs:
3636
steps:
3737
- name: Checkout PyTorch
3838
uses: actions/checkout@v2
39+
with:
40+
submodules: recursive
3941
- name: Install Visual Studio 2019 toolchain
4042
shell: powershell
4143
run: |
@@ -73,6 +75,8 @@ jobs:
7375
steps:
7476
- name: Checkout PyTorch
7577
uses: actions/checkout@v2
78+
with:
79+
submodules: recursive
7680
- name: Install Visual Studio 2019 toolchain
7781
shell: powershell
7882
run: |

‎.github/workflows/build_linux_conda.yml‎

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,22 @@ jobs:
9191
with:
9292
name: pytorch-conda-py${{ matrix.python_version }}-${{matrix.gpu_arch_type}}-${{ matrix.gpu_arch_version }}
9393
path: /remote/**/*.bz2
94-
# TODO: Add a step here for uploading binaries
94+
- name: Display and upload binary build size statistics (Click Me)
95+
# temporary hack: set CIRCLE_* vars, until we update
96+
# tools/print_test_stats.py to natively support GitHub Actions
97+
env:
98+
SCRIBE_GRAPHQL_ACCESS_TOKEN: ${{ secrets.SCRIBE_GRAPHQL_ACCESS_TOKEN }}
99+
CIRCLE_BRANCH: ${{ steps.parse-ref.outputs.branch }}
100+
CIRCLE_PR_NUMBER: ${{ github.event.pull_request.number }}
101+
CIRCLE_SHA1: ${{ github.event.pull_request.head.sha || github.sha }}
102+
CIRCLE_TAG: ${{ steps.parse-ref.outputs.tag }}
103+
CIRCLE_WORKFLOW_ID: ${{ github.run_id }} # dunno if this corresponds
104+
run: |
105+
export PYTHONPATH=$PWD
106+
COMMIT_TIME=$(git log --max-count=1 --format=%ct || echo 0)
107+
export COMMIT_TIME
108+
pip3 install requests
109+
python3 .circleci/scripts/upload_binary_size_to_scuba.py || exit 0
95110
96111
concurrency:
97112
group: build-linux-conda-${{ github.event.pull_request.number || github.sha }}

‎.github/workflows/build_linux_libtorch.yml‎

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,22 @@ jobs:
9090
with:
9191
name: pytorch-libtorch-${{ matrix.libtorch_variant }}-${{ matrix.devtoolset }}-${{matrix.gpu_arch_type}}-${{ matrix.gpu_arch_version }}
9292
path: /remote/**/*.zip
93-
# TODO: Add a step here for uploading binaries
93+
- name: Display and upload binary build size statistics (Click Me)
94+
# temporary hack: set CIRCLE_* vars, until we update
95+
# tools/print_test_stats.py to natively support GitHub Actions
96+
env:
97+
SCRIBE_GRAPHQL_ACCESS_TOKEN: ${{ secrets.SCRIBE_GRAPHQL_ACCESS_TOKEN }}
98+
CIRCLE_BRANCH: ${{ steps.parse-ref.outputs.branch }}
99+
CIRCLE_PR_NUMBER: ${{ github.event.pull_request.number }}
100+
CIRCLE_SHA1: ${{ github.event.pull_request.head.sha || github.sha }}
101+
CIRCLE_TAG: ${{ steps.parse-ref.outputs.tag }}
102+
CIRCLE_WORKFLOW_ID: ${{ github.run_id }} # dunno if this corresponds
103+
run: |
104+
export PYTHONPATH=$PWD
105+
COMMIT_TIME=$(git log --max-count=1 --format=%ct || echo 0)
106+
export COMMIT_TIME
107+
pip3 install requests
108+
python3 .circleci/scripts/upload_binary_size_to_scuba.py || exit 0
94109
95110
concurrency:
96111
group: build-linux-libtorch-${{ github.event.pull_request.number || github.sha }}

‎.github/workflows/build_linux_wheels.yml‎

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,22 @@ jobs:
8989
with:
9090
name: pytorch-wheel-py${{ matrix.python_version }}-${{matrix.gpu_arch_type}}-${{ matrix.gpu_arch_version }}
9191
path: /remote/**/*.whl
92-
# TODO: Add a step here for uploading binaries
92+
- name: Display and upload binary build size statistics (Click Me)
93+
# temporary hack: set CIRCLE_* vars, until we update
94+
# tools/print_test_stats.py to natively support GitHub Actions
95+
env:
96+
SCRIBE_GRAPHQL_ACCESS_TOKEN: ${{ secrets.SCRIBE_GRAPHQL_ACCESS_TOKEN }}
97+
CIRCLE_BRANCH: ${{ steps.parse-ref.outputs.branch }}
98+
CIRCLE_PR_NUMBER: ${{ github.event.pull_request.number }}
99+
CIRCLE_SHA1: ${{ github.event.pull_request.head.sha || github.sha }}
100+
CIRCLE_TAG: ${{ steps.parse-ref.outputs.tag }}
101+
CIRCLE_WORKFLOW_ID: ${{ github.run_id }} # dunno if this corresponds
102+
run: |
103+
export PYTHONPATH=$PWD
104+
COMMIT_TIME=$(git log --max-count=1 --format=%ct || echo 0)
105+
export COMMIT_TIME
106+
pip3 install requests
107+
python3 .circleci/scripts/upload_binary_size_to_scuba.py || exit 0
93108
94109
concurrency:
95110
group: build-linux-wheels-${{ github.event.pull_request.number || github.sha }}

‎.github/workflows/pytorch-linux-xenial-cuda10.2-cudnn7-py3.6-gcc7.yml‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,22 @@ jobs:
139139
-w /var/lib/jenkins/workspace \
140140
"${DOCKER_IMAGE}" \
141141
sh -c 'sudo chown -R jenkins . && .jenkins/pytorch/build.sh'
142+
- name: Display and upload binary build size statistics (Click Me)
143+
# temporary hack: set CIRCLE_* vars, until we update
144+
# tools/print_test_stats.py to natively support GitHub Actions
145+
env:
146+
SCRIBE_GRAPHQL_ACCESS_TOKEN: ${{ secrets.SCRIBE_GRAPHQL_ACCESS_TOKEN }}
147+
CIRCLE_BRANCH: ${{ steps.parse-ref.outputs.branch }}
148+
CIRCLE_PR_NUMBER: ${{ github.event.pull_request.number }}
149+
CIRCLE_SHA1: ${{ github.event.pull_request.head.sha || github.sha }}
150+
CIRCLE_TAG: ${{ steps.parse-ref.outputs.tag }}
151+
CIRCLE_WORKFLOW_ID: ${{ github.run_id }} # dunno if this corresponds
152+
run: |
153+
export PYTHONPATH=$PWD
154+
COMMIT_TIME=$(git log --max-count=1 --format=%ct || echo 0)
155+
export COMMIT_TIME
156+
pip3 install requests
157+
python3 .circleci/scripts/upload_binary_size_to_scuba.py || exit 0
142158
- name: Chown workspace
143159
run: |
144160
# Ensure the working directory gets chowned back to the current user
@@ -190,6 +206,8 @@ jobs:
190206
docker run --rm -v "$(pwd)/../":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .
191207
- name: Checkout PyTorch
192208
uses: actions/checkout@v2
209+
with:
210+
submodules: recursive
193211
- name: Pull docker image
194212
run: |
195213
docker pull "${DOCKER_IMAGE}"

‎.github/workflows/pytorch-linux-xenial-py3.6-gcc5.4.yml‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,22 @@ jobs:
140140
-w /var/lib/jenkins/workspace \
141141
"${DOCKER_IMAGE}" \
142142
sh -c 'sudo chown -R jenkins . && .jenkins/pytorch/build.sh'
143+
- name: Display and upload binary build size statistics (Click Me)
144+
# temporary hack: set CIRCLE_* vars, until we update
145+
# tools/print_test_stats.py to natively support GitHub Actions
146+
env:
147+
SCRIBE_GRAPHQL_ACCESS_TOKEN: ${{ secrets.SCRIBE_GRAPHQL_ACCESS_TOKEN }}
148+
CIRCLE_BRANCH: ${{ steps.parse-ref.outputs.branch }}
149+
CIRCLE_PR_NUMBER: ${{ github.event.pull_request.number }}
150+
CIRCLE_SHA1: ${{ github.event.pull_request.head.sha || github.sha }}
151+
CIRCLE_TAG: ${{ steps.parse-ref.outputs.tag }}
152+
CIRCLE_WORKFLOW_ID: ${{ github.run_id }} # dunno if this corresponds
153+
run: |
154+
export PYTHONPATH=$PWD
155+
COMMIT_TIME=$(git log --max-count=1 --format=%ct || echo 0)
156+
export COMMIT_TIME
157+
pip3 install requests
158+
python3 .circleci/scripts/upload_binary_size_to_scuba.py || exit 0
143159
- name: Chown workspace
144160
run: |
145161
# Ensure the working directory gets chowned back to the current user
@@ -191,6 +207,8 @@ jobs:
191207
docker run --rm -v "$(pwd)/../":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .
192208
- name: Checkout PyTorch
193209
uses: actions/checkout@v2
210+
with:
211+
submodules: recursive
194212
- name: Pull docker image
195213
run: |
196214
docker pull "${DOCKER_IMAGE}"

‎.github/workflows/pytorch-win-vs2019-cpu-py3.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ jobs:
3535
steps:
3636
- name: Checkout PyTorch
3737
uses: actions/checkout@v2
38+
with:
39+
submodules: recursive
3840
- name: Install Visual Studio 2019 toolchain
3941
shell: powershell
4042
run: |
@@ -72,6 +74,8 @@ jobs:
7274
steps:
7375
- name: Checkout PyTorch
7476
uses: actions/checkout@v2
77+
with:
78+
submodules: recursive
7579
- name: Install Visual Studio 2019 toolchain
7680
shell: powershell
7781
run: |

0 commit comments

Comments
 (0)