Guard against negative rpcTimeout being passed in to RpcBackendOptions (#38267)

osalpekar · facebook-github-bot · commit b57a339703fb · 2020-05-14T11:33:23.000-07:00
Summary: Pull Request resolved: #38267 Assert that the rpcTimeout is positive in RpcBackendOptions constructor ghstack-source-id: 104029918 Test Plan: CI Differential Revision: D21509850 fbshipit-source-id: c925490e3d8fa2ffa42b0ae1170ca2f740af11f7
diff --git a/torch/csrc/distributed/rpc/rpc_agent.h b/torch/csrc/distributed/rpc/rpc_agent.h
@@ -32,7 +32,9 @@ struct RpcBackendOptions {
 
   RpcBackendOptions(float rpcTimeoutSeconds, std::string initMethod)
       : rpcTimeoutSeconds(rpcTimeoutSeconds),
-        initMethod(std::move(initMethod)) {}
+        initMethod(std::move(initMethod)) {
+    TORCH_CHECK(rpcTimeoutSeconds >= 0, "RPC Timeout must be non-negative");
+  }
 
   float rpcTimeoutSeconds;
   std::string initMethod;
