Get TestTorch.test_empty_meta working again (#48113)

ezyang · facebook-github-bot · commit a97d0596146f · 2020-11-18T19:50:27.000-08:00
Summary: Pull Request resolved: #48113 Fix is simple: just treat Meta as a backend covered by AutogradOther. This semantically makes sense, since meta kernels are just like regular CPU/CUDA kernels, they just don't do any compute. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: zhangguanheng66 Differential Revision: D25056641 Pulled By: ezyang fbshipit-source-id: 7b68911982352b3e0ee8616b38cd9c70bd58a740
diff --git a/c10/core/DispatchKeySet.h b/c10/core/DispatchKeySet.h
@@ -188,6 +188,7 @@ C10_API std::ostream& operator<<(std::ostream&, DispatchKeySet);
 
 // autograd_dispatch_keyset should include all runtime autograd keys.
 // Alias key DispatchKey::Autograd maps to autograd_dispatch_keyset.
+// NB: keys in this set also get associated with Math
 constexpr DispatchKeySet autograd_dispatch_keyset = DispatchKeySet({
   DispatchKey::AutogradCPU,
   DispatchKey::AutogradCUDA,
@@ -200,6 +201,7 @@ constexpr DispatchKeySet autograd_dispatch_keyset = DispatchKeySet({
 });
 
 // backend dispatch keys that map to DispatchKey::AutogradOther
+// NB: keys in this set also get associated with Math
 constexpr DispatchKeySet autogradother_backends = DispatchKeySet({
   DispatchKey::HIP,
   DispatchKey::FPGA,
@@ -219,6 +221,7 @@ constexpr DispatchKeySet autogradother_backends = DispatchKeySet({
   DispatchKey::SparseCPU,
   DispatchKey::SparseCUDA,
   DispatchKey::SparseHIP,
+  DispatchKey::Meta,
 });
 
 // true if t is a backend dispatch key
diff --git a/test/test_torch.py b/test/test_torch.py
@@ -4472,7 +4472,6 @@ def test_batch_norm_cpu_inference(self):
                     self.assertEqual(output3, output1)
                     self.assertEqual(output3, output2)
 
-        @unittest.skipIf(True, "Skip due to catchAll -> Math")
         def test_empty_meta(self):
             x = torch.empty_meta(2 ** 20, 2 ** 20)
             y = torch.empty_meta(2 ** 20)
