Skip to content

Commit a8f9d8b

Browse files
rohan-varmarohan-varma
committed
Update on "Add an option to run RPC tests with TCP init"
 We have found a few bugs where initializing/de-initializing/re-initializing RPC, and using RPC along with process groups does not work as expected, usually under TCP/env initialization (which is used over `file` which is the init that we use in our test in multi-machine scenarios). Due to this motivation, this PR adds an environment variable `RPC_INIT_WITH_TCP` that allows us to run any RPC test with TCP initialization. To avoid port collisions, we use `common.find_free_port()`. Differential Revision: [D25085458](https://our.internmc.facebook.com/intern/diff/D25085458/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25085458/)! [ghstack-poisoned]
2 parents 21e9af6 + ccd20e9 commit a8f9d8b

189 files changed

Lines changed: 19172 additions & 16964 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.circleci/cimodel/data/binary_build_data.py‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@ def get_processor_arch_name(gpu_version):
3030
"cu" + gpu_version.strip("cuda") if gpu_version.startswith("cuda") else gpu_version
3131
)
3232

33-
PYTHON_NO_39 = [
34-
v for v in dimensions.STANDARD_PYTHON_VERSIONS if v not in ['3.9']
35-
]
36-
3733
LINUX_PACKAGE_VARIANTS = OrderedDict(
3834
manywheel=[
3935
"3.6m",
@@ -60,8 +56,8 @@ def get_processor_arch_name(gpu_version):
6056
windows=(
6157
[v for v in dimensions.GPU_VERSIONS if v not in ['cuda92'] + dimensions.ROCM_VERSION_LABELS],
6258
OrderedDict(
63-
wheel=PYTHON_NO_39,
64-
conda=PYTHON_NO_39,
59+
wheel=dimensions.STANDARD_PYTHON_VERSIONS,
60+
conda=dimensions.STANDARD_PYTHON_VERSIONS,
6561
libtorch=[
6662
"3.7",
6763
],

‎.circleci/cimodel/data/windows_build_definitions.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,10 +131,10 @@ def TruePred(_):
131131
WindowsJob(None, _VC2019, CudaVersion(10, 1)),
132132
WindowsJob(1, _VC2019, CudaVersion(10, 1)),
133133
WindowsJob(2, _VC2019, CudaVersion(10, 1)),
134-
# VS2019 CUDA-11.0
135-
WindowsJob(None, _VC2019, CudaVersion(11, 0)),
136-
WindowsJob(1, _VC2019, CudaVersion(11, 0), master_only_pred=TruePred),
137-
WindowsJob(2, _VC2019, CudaVersion(11, 0), master_only_pred=TruePred),
134+
# VS2019 CUDA-11.1
135+
WindowsJob(None, _VC2019, CudaVersion(11, 1)),
136+
WindowsJob(1, _VC2019, CudaVersion(11, 1), master_only_pred=TruePred),
137+
WindowsJob(2, _VC2019, CudaVersion(11, 1), master_only_pred=TruePred),
138138
# VS2019 CPU-only
139139
WindowsJob(None, _VC2019, None),
140140
WindowsJob(1, _VC2019, None, master_only_pred=TruePred),

0 commit comments

Comments
 (0)