Enable clang-tidy in torch/csrc/quantized and some fixes (#113604)

cyyever · pytorchmergebot · commit 79e3833703c4 · 2023-11-14T16:51:18.000Z
This PR enables clang-tidy checks in torch/csrc/quantized/ Pull Request resolved: #113604 Approved by: https://github.com/Skylion007
diff --git a/.lintrunner.toml b/.lintrunner.toml
@@ -267,7 +267,6 @@ exclude_patterns = [
     'torch/csrc/jit/serialization/export.cpp',
     'torch/csrc/lazy/**/*',
     'torch/csrc/onnx/init.cpp',
-    'torch/csrc/quantized/**/*',
     'torch/csrc/mps/**/*',
 ]
 init_command = [
diff --git a/torch/csrc/quantized/quantized_backward.cpp b/torch/csrc/quantized/quantized_backward.cpp
@@ -30,16 +30,19 @@ class PackedLinearWeightDynamicBackward
                     c10::detail::intrusive_target_default_null_type<
                         LinearPackedParamsBase>> const&,
                 bool)>();
-    auto output = op.redispatch(
-        DispatchKeySet({DispatchKey::CPU}), input, packed_weight, reduce_range);
-    auto input_contig = input.contiguous();
     // Calculate statistics for quantization of input Tensor
     float x_min = 0;
     float x_max = 0;
     if (input.numel() > 0) {
+      auto input_contig = input.contiguous();
       x_min = input_contig.min().item<float>();
       x_max = input_contig.max().item<float>();
     }
+    auto output = op.redispatch(
+        DispatchKeySet({DispatchKey::CPU}),
+        std::move(input),
+        packed_weight,
+        reduce_range);
     auto q_params = quant_utils::ChooseQuantizationParams(
         /*min=*/x_min,
         /*max=*/x_max,
@@ -147,7 +150,7 @@ at::Tensor packed_linear_weight_grad(
     const c10::intrusive_ptr<LinearPackedParamsBase>& packed_weight,
     bool reduce_range) {
   return PackedLinearWeightDynamicBackward::apply(
-      input, packed_weight, reduce_range);
+      std::move(input), packed_weight, reduce_range);
 }
 } // namespace
 

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,6 @@ exclude_patterns = [`
`267`	`267`	`'torch/csrc/jit/serialization/export.cpp',`
`268`	`268`	`'torch/csrc/lazy/*/',`
`269`	`269`	`'torch/csrc/onnx/init.cpp',`
`270`		`- 'torch/csrc/quantized/*/',`
`271`	`270`	`'torch/csrc/mps/*/',`
`272`	`271`	`]`
`273`	`272`	`init_command = [`