Skip to content

Commit 6c9bfd5

Browse files
jithunnair-amdpytorchmergebot
authored andcommitted
[ROCm][CI] upgrade CI to ROCm 6.2.4 (#140851)
Fixes issue of long docker build times in PRs which trigger the docker build in regular PyTorch build jobs eg. https://github.com/pytorch/pytorch/actions/runs/11751388838/job/32828886198. These docker builds take a long time for ROCm6.2 because: 1. They are run on less capable machines (`c5.2xlarge`) instead of the beefier ones on which [docker-build workflows](https://github.com/pytorch/pytorch/blob/924c1fe3f304aa599b823fb549c35b7809f61086/.github/workflows/docker-builds.yml#L50) run (`c5.12xlarge`) 2. ROCm6.2 docker builds enabled building of MIOpen from source, which runs into [timeout of 90mins](https://github.com/pytorch/test-infra/blob/9abd4d95bb0b86d78d1929abcd6046d07e8a5864/.github/actions/calculate-docker-image/action.yml#L171): https://github.com/pytorch/pytorch/actions/runs/11751388838/job/32828886198#step:7:160 Pull Request resolved: #140851 Approved by: https://github.com/jeffdaily
1 parent 04f569a commit 6c9bfd5

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

.ci/docker/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ case "$image" in
292292
PROTOBUF=yes
293293
DB=yes
294294
VISION=yes
295-
ROCM_VERSION=6.2
295+
ROCM_VERSION=6.2.4
296296
NINJA_VERSION=1.9.0
297297
CONDA_CMAKE=yes
298298
TRITON=yes

.ci/docker/common/install_miopen.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,10 @@ MIOPEN_CMAKE_COMMON_FLAGS="
7575
if [[ $ROCM_INT -ge 60300 ]]; then
7676
echo "ROCm 6.3+ MIOpen does not need any patches, do not build from source"
7777
exit 0
78-
elif [[ $ROCM_INT -ge 60200 ]] && [[ $ROCM_INT -lt 60300 ]]; then
78+
elif [[ $ROCM_INT -ge 60204 ]] && [[ $ROCM_INT -lt 60300 ]]; then
79+
echo "ROCm 6.2.4+ MIOpen does not need any patches, do not build from source"
80+
exit 0
81+
elif [[ $ROCM_INT -ge 60200 ]] && [[ $ROCM_INT -lt 60204 ]]; then
7982
MIOPEN_BRANCH="release/rocm-rel-6.2-staging"
8083
elif [[ $ROCM_INT -ge 60100 ]] && [[ $ROCM_INT -lt 60200 ]]; then
8184
echo "ROCm 6.1 MIOpen does not need any patches, do not build from source"

.github/workflows/build-manywheel-images.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ jobs:
178178
runs-on: "${{ needs.get-label-type.outputs.label-type }}linux.9xlarge.ephemeral"
179179
strategy:
180180
matrix:
181-
rocm_version: ["6.1", "6.2"]
181+
rocm_version: ["6.1", "6.2.4"]
182182
env:
183183
GPU_ARCH_TYPE: rocm
184184
GPU_ARCH_VERSION: ${{ matrix.rocm_version }}

0 commit comments

Comments
 (0)