Skip to content

Commit 5e55f08

Browse files
lixinyufacebook-github-bot
authored andcommitted
override gcc version in cuda related test (#38675)
Summary: Pull Request resolved: #38675 Test Plan: Imported from OSS Differential Revision: D21626921 Pulled By: glaringlee fbshipit-source-id: b645845aa831cb64078fe2309881038138abb443
1 parent fc19747 commit 5e55f08

3 files changed

Lines changed: 42 additions & 2 deletions

File tree

.circleci/cimodel/data/pytorch_build_data.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,12 @@
2323
]),
2424
]),
2525
("cuda", [
26-
("9.2", [X("3.6")]),
26+
("9.2", [
27+
X("3.6"),
28+
("3.6", [
29+
("cuda_gcc_override", [X("gcc5.4")])
30+
])
31+
]),
2732
("10.1", [X("3.6")]),
2833
("10.2", [
2934
XImportant("3.6"),
@@ -126,6 +131,7 @@ def child_constructor(self):
126131
"libtorch": LibTorchConfigNode,
127132
"important": ImportantConfigNode,
128133
"android_abi": AndroidAbiConfigNode,
134+
"cuda_gcc_override": CudaGccOverrideConfigNode
129135
}
130136
return next_nodes[experimental_feature]
131137

@@ -182,6 +188,12 @@ def init2(self, node_name):
182188
def child_constructor(self):
183189
return ImportantConfigNode
184190

191+
class CudaGccOverrideConfigNode(TreeConfigNode):
192+
def init2(self, node_name):
193+
self.props["cuda_gcc_override"] = node_name
194+
195+
def child_constructor(self):
196+
return ImportantConfigNode
185197

186198
class ImportantConfigNode(TreeConfigNode):
187199
def modify_label(self, label):

.circleci/cimodel/data/pytorch_build_definitions.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,8 @@ def instantiate_configs():
221221

222222
if cuda_version in ["9.2", "10", "10.1", "10.2"]:
223223
# TODO The gcc version is orthogonal to CUDA version?
224-
parms_list.append("gcc7")
224+
cuda_gcc_version = fc.find_prop("cuda_gcc_override") or "gcc7"
225+
parms_list.append(cuda_gcc_version)
225226

226227
is_libtorch = fc.find_prop("is_libtorch") or False
227228
is_important = fc.find_prop("is_important") or False

.circleci/config.yml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2593,6 +2593,33 @@ workflows:
25932593
docker_image: "308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-cuda9.2-cudnn7-py3-gcc7:9a3986fa-7ce7-4a36-a001-3c9bef9892e2"
25942594
use_cuda_docker_runtime: "1"
25952595
resource_class: gpu.medium
2596+
- pytorch_linux_build:
2597+
name: pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build
2598+
requires:
2599+
- setup
2600+
filters:
2601+
branches:
2602+
only:
2603+
- master
2604+
- /ci-all\/.*/
2605+
- /release\/.*/
2606+
build_environment: "pytorch-linux-xenial-cuda9.2-cudnn7-py3-gcc5.4-build"
2607+
docker_image: "308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-cuda9.2-cudnn7-py3-gcc5.4:9a3986fa-7ce7-4a36-a001-3c9bef9892e2"
2608+
- pytorch_linux_test:
2609+
name: pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_test
2610+
requires:
2611+
- setup
2612+
- pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build
2613+
filters:
2614+
branches:
2615+
only:
2616+
- master
2617+
- /ci-all\/.*/
2618+
- /release\/.*/
2619+
build_environment: "pytorch-linux-xenial-cuda9.2-cudnn7-py3-gcc5.4-test"
2620+
docker_image: "308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-cuda9.2-cudnn7-py3-gcc5.4:9a3986fa-7ce7-4a36-a001-3c9bef9892e2"
2621+
use_cuda_docker_runtime: "1"
2622+
resource_class: gpu.medium
25962623
- pytorch_linux_build:
25972624
name: pytorch_linux_xenial_cuda10_1_cudnn7_py3_gcc7_build
25982625
requires:

0 commit comments

Comments
 (0)