Skip to content

Commit 4ce76d0

Browse files
ezyangezyang
committed
Update on "Make add.Scalar manual_cpp_binding"
 Manually do add.Scalar binding, skipping dispatch when you call into it from C++. This doesn't help if you directly get to the kernel via JIT interpreter though. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D25594995](https://our.internmc.facebook.com/intern/diff/D25594995) [ghstack-poisoned]
2 parents abc7df7 + cf428ee commit 4ce76d0

136 files changed

Lines changed: 1419 additions & 3277 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.circleci/config.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ parameters:
1111
run_binary_tests:
1212
type: boolean
1313
default: false
14+
run_build:
15+
type: boolean
16+
default: true
1417

1518
docker_config_defaults: &docker_config_defaults
1619
user: jenkins
@@ -9762,6 +9765,7 @@ workflows:
97629765
only:
97639766
- postnightly
97649767
executor: windows-with-nvidia-gpu
9768+
when: << pipeline.parameters.run_build >>
97659769
ecr_gc:
97669770
triggers:
97679771
- schedule:

‎.circleci/generate_config_yml.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,10 @@ def gen_build_workflows_tree():
112112
"when": r"<< pipeline.parameters.run_binary_tests >>",
113113
"jobs": [f() for f in binary_build_functions],
114114
},
115-
"build": {"jobs": [f() for f in build_workflows_functions]},
115+
"build": {
116+
"when": r"<< pipeline.parameters.run_build >>",
117+
"jobs": [f() for f in build_workflows_functions]
118+
},
116119
}
117120
}
118121

‎.circleci/verbatim-sources/header-section.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ parameters:
1111
run_binary_tests:
1212
type: boolean
1313
default: false
14+
run_build:
15+
type: boolean
16+
default: true
1417

1518
docker_config_defaults: &docker_config_defaults
1619
user: jenkins

‎.github/pytorch-circleci-labels.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,5 @@ labels_to_circle_params:
99
- release/.*
1010
tags:
1111
- v[0-9]+(\.[0-9]+)*-rc[0-9]+
12+
set_to_false:
13+
- run_build

‎.jenkins/pytorch/codegen-test.sh‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,6 @@ python -m tools.autograd.gen_autograd \
4848
"$OUT"/autograd \
4949
tools/autograd
5050

51-
# unboxing_wrappers codegen (called by torch codegen but can run independently)
52-
mkdir -p "$OUT"/unboxing_wrappers
53-
python -m tools.jit.gen_unboxing_wrappers \
54-
"$OUT"/torch/share/ATen/Declarations.yaml \
55-
"$OUT"/unboxing_wrappers \
56-
tools/jit/templates
57-
5851
# annotated_fn_args codegen (called by torch codegen but can run independently)
5952
mkdir -p "$OUT"/annotated_fn_args
6053
python -m tools.autograd.gen_annotated_fn_args \

‎.jenkins/pytorch/macos-test.sh‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@ pip install -q hypothesis "librosa>=0.6.2" "numba<=0.49.1" psutil
99
# TODO move this to docker
1010
pip install unittest-xml-reporting pytest
1111

12-
# faulthandler become built-in since 3.3
13-
if [[ ! $(python -c "import sys; print(int(sys.version_info >= (3, 3)))") == "1" ]]; then
14-
pip install -q faulthandler
15-
fi
16-
1712
if [ -z "${IN_CI}" ]; then
1813
rm -rf ${WORKSPACE_DIR}/miniconda3/lib/python3.6/site-packages/torch*
1914
fi

‎.jenkins/pytorch/win-test-helpers/setup_pytorch_env.bat‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ popd
4141
:: The version is fixed to avoid flakiness: https://github.com/pytorch/pytorch/issues/31136
4242
pip install "ninja==1.10.0.post1" future "hypothesis==4.53.2" "librosa>=0.6.2" psutil pillow unittest-xml-reporting pytest coverage
4343
if %errorlevel% neq 0 ( exit /b %errorlevel% )
44-
:: No need to install faulthandler since we only test Python >= 3.6 on Windows
45-
:: faulthandler is builtin since Python 3.3
4644

4745
set DISTUTILS_USE_SDK=1
4846

‎BUILD.bazel‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,9 +195,6 @@ libtorch_cpp_generated_sources = [
195195
"torch/csrc/autograd/generated/Functions.h",
196196
"torch/csrc/autograd/generated/Functions.cpp",
197197
"torch/csrc/autograd/generated/variable_factories.h",
198-
"torch/csrc/jit/generated/generated_unboxing_wrappers_0.cpp",
199-
"torch/csrc/jit/generated/generated_unboxing_wrappers_1.cpp",
200-
"torch/csrc/jit/generated/generated_unboxing_wrappers_2.cpp",
201198
]
202199

203200
libtorch_python_generated_sources = [

‎android/test_app/app/src/main/AndroidManifest.xml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,10 @@
1818
</application>
1919

2020
<uses-permission android:name="android.permission.CAMERA" />
21+
22+
<!--
23+
Permissions required by the Snapdragon Profiler to collect GPU metrics.
24+
-->
25+
<uses-permission android:name="android.permission.INTERNET" />
26+
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
2127
</manifest>

‎aten/conda/meta.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ requirements:
2424
- mkl # [not osx]
2525

2626
about:
27-
home: https://github.com/zdevito/ATen
27+
home: https://github.com/pytorch/pytorch
2828
license: BSD
2929
summary: A TENsor library for C++14
3030

0 commit comments

Comments
 (0)