Add multiple span route support#215
Merged
guotuofeng merged 48 commits intoplugin/0.2from Jun 3, 2021
Merged
Conversation
Contributor
Author
guyang3532
reviewed
May 17, 2021
guyang3532
reviewed
May 19, 2021
guyang3532
reviewed
May 19, 2021
guyang3532
reviewed
May 19, 2021
gaoteng-git
reviewed
Jun 3, 2021
| WORKER_PATTERN = re.compile(r"""^(.*?) # worker name | ||
| # TODO: uncomment the following line when we need supprort multiple steps | ||
| # (?:\.\d+)? # optional timestamp like 1619499959628 | ||
| (\.\d+)? # optional timestamp like 1619499959628 used as step name |
Contributor
There was a problem hiding this comment.
used as "span time", not "step time".
| worker = match.group(1) | ||
| workers.append((worker, path)) | ||
| span = match.group(2) | ||
| if span: |
Contributor
There was a problem hiding this comment.
Have you tested that when match.group(2) fails then span will be None?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add multiple span route support (part 1)