Add pure python platform-agnostic wheel#988
Closed
ejguan wants to merge 3 commits intometa-pytorch:mainfrom
Closed
Add pure python platform-agnostic wheel#988ejguan wants to merge 3 commits intometa-pytorch:mainfrom
ejguan wants to merge 3 commits intometa-pytorch:mainfrom
Conversation
d2365f9 to
64b67d9
Compare
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
reviewed
Feb 6, 2023
Contributor
NivekT
left a comment
There was a problem hiding this comment.
Questions:
- Will this be the default installation going forward?
- Do we need to update the installation instructions in README?
Contributor
Author
Like I said in the issue. This wheel would be the backup package when none of platform specific wheels fit into users' machine. If
No thing needs to be updated IMO. |
NivekT
approved these changes
Feb 6, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #973
Release workflow can be found: https://github.com/pytorch/data/actions/runs/4108506783/jobs/7089283333