Prevent reset iteration message sent twice to workers#917
Closed
ejguan wants to merge 2 commits intometa-pytorch:mainfrom
Closed
Prevent reset iteration message sent twice to workers#917ejguan wants to merge 2 commits intometa-pytorch:mainfrom
ejguan wants to merge 2 commits intometa-pytorch:mainfrom
Conversation
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Dec 8, 2022
Contributor
NivekT
left a comment
There was a problem hiding this comment.
LGTM! Just one question to make sure it is right.
| dist_info = _DistInfo(shared_seed_int, self._world_size, self._rank) | ||
| call_on_epoch_reset = partial(process_reset_fn, dist_info=dist_info, custom_reset_fn=self.worker_reset_fn) | ||
| end_datapipe.reset_epoch(call_on_epoch_reset) | ||
| end_datapipe.reset() |
Contributor
There was a problem hiding this comment.
Do we need to call this when self.main_prefetch_cnt <= 0?
Contributor
Author
There was a problem hiding this comment.
Not needed because reset is always called for each iteration of datapipe.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
end_datapipe.reset()as it's going to be invoked at the beginning of iteration.nit changes
mp_ctxcreation out of loop