update load_state_dict() signature to align with torchsnapshot#887
Closed
xunnanxu wants to merge 1 commit intometa-pytorch:mainfrom
Closed
update load_state_dict() signature to align with torchsnapshot#887xunnanxu wants to merge 1 commit intometa-pytorch:mainfrom
xunnanxu wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
Summary: Checkpointing relies on some protocol checking to make sure it takes `Checkpointable` modules. The canonical protocol currently requires `def load_state_dict(self, state_dict: Dict[str, Any]) -> None:` but DLv2's positional argument is `state` instead. So even though logically everything works this breaks static type checking, creating confusion to users. See signature https://github.com/pytorch/torchsnapshot/blob/28ce508ceb1db0a4f16c269b776fe88216e340f5/torchsnapshot/stateful.py#L14 Reviewed By: Miiira Differential Revision: D41094635 fbshipit-source-id: 4215bb653b22728a36a066b534939d563f622bfb
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41094635 |
NivekT
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Checkpointing relies on some protocol checking to make sure it takes
Checkpointablemodules.The canonical protocol currently requires
def load_state_dict(self, state_dict: Dict[str, Any]) -> None:but DLv2's positional argument isstateinstead.So even though logically everything works this breaks static type checking, creating confusion to users.
See signature
https://github.com/pytorch/torchsnapshot/blob/28ce508ceb1db0a4f16c269b776fe88216e340f5/torchsnapshot/stateful.py#L14
Reviewed By: Miiira
Differential Revision: D41094635